Skip to content

Feat/rework-perferences#4915

Open
ajnart wants to merge 5 commits intodevfrom
feat/rework-perferences
Open

Feat/rework-perferences#4915
ajnart wants to merge 5 commits intodevfrom
feat/rework-perferences

Conversation

@ajnart
Copy link
Member

@ajnart ajnart commented Jan 25, 2026 •
edited
Loading

rework the preferences screen

more pretty and has a prevention to not go out of the page by mistake with unsaved changes

CleanShot 2026-01-25 at 15 59 47@2x

@ajnart ajnart requested a review from a team as a code owner January 25, 2026 15:00
@deepsource-io
Copy link
Contributor

deepsource-io bot commented Jan 25, 2026 •
edited
Loading

Here's the code health analysis summary for commits 2354510..e79efe0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Meierschlumpf
Meierschlumpf requested changes Jan 27, 2026
View reviewed changes
@ajnart ajnart requested a review from Meierschlumpf January 28, 2026 10:45
@ajnart
Copy link
Member Author

ajnart commented Jan 28, 2026

@Meierschlumpf I addressed the comments. In the end I switched to tanstack form for the form

@Meierschlumpf
Copy link
Member

Meierschlumpf commented Jan 28, 2026

Why not mantine form with integrated zod validation from homarr/form?

@ajnart
Copy link
Member Author

ajnart commented Jan 28, 2026

Why not mantine form with integrated zod validation from homarr/form?

I didn't know we had @homarr/form xD

@ajnart
Copy link
Member Author

ajnart commented Feb 5, 2026

@Meierschlumpf I moved to homarr form now, feel free to re-review whenever

@ajnart ajnart mentioned this pull request Feb 5, 2026
Open
@Meierschlumpf
Copy link
Member

Meierschlumpf commented Feb 6, 2026

Can you please combine the mutations into one?

@ajnart
Copy link
Member Author

ajnart commented Feb 10, 2026

Can you please combine the mutations into one?

This is outside of the scope of this PR imo, we made all of these mutations and used them before.
I tried prototyping a updateSettings procedure using a schema built from the sum of all of the types in https://github.com/homarr-labs/homarr/blob/1bb3654bf7fffa6724d606991b12ea29d7c1d0c8/packages/validation/src/user.ts but it seems like a big refactor because the return type needs to be inferred from what's in the input or not. I'd love to take a look at it in a separate PR tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meierschlumpf Meierschlumpf Awaiting requested review from Meierschlumpf

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajnart @Meierschlumpf